Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tree key ts type #23348

Merged
merged 2 commits into from Apr 17, 2020
Merged

fix: fix tree key ts type #23348

merged 2 commits into from Apr 17, 2020

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 17, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #23335

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English ts type upgrade
馃嚚馃嚦 Chinese 鏇存柊tree绫诲瀷 ts瀹氫箟

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Apr 17, 2020
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 17, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef756ef:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 17, 2020

Codecov Report

Merging #23348 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23348   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         364      364           
  Lines        7279     7279           
  Branches     1983     1993   +10     
=======================================
  Hits         7160     7160           
  Misses        119      119           
Impacted Files Coverage 螖
components/tree/DirectoryTree.tsx 97.89% <酶> (酶)
components/tree/Tree.tsx 100.00% <酶> (酶)
components/tree/utils/dictUtil.ts 95.12% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6c45186...ef756ef. Read the comment docs.

@yoyo837
Copy link
Contributor Author

@yoyo837 yoyo837 commented Apr 17, 2020

鏈湴jest鏈夐棶棰橈紒馃槖

@yoyo837 yoyo837 marked this pull request as ready for review Apr 17, 2020
@yoyo837 yoyo837 requested a review from zombieJ as a code owner Apr 17, 2020
@zombieJ zombieJ merged commit c70b49a into master Apr 17, 2020
31 checks passed
@zombieJ zombieJ deleted the fix-tree-ts branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants