Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal.info onOk execute times #23360

Merged
merged 4 commits into from Apr 17, 2020
Merged

fix: Modal.info onOk execute times #23360

merged 4 commits into from Apr 17, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23358

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Modal.info executed only once when has argument.
🇨🇳 Chinese 修复 Modal.info 等方法的 onOk 函数有参数时只触发一次的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/modal/index.en-US.md
View rendered components/modal/index.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Apr 17, 2020
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 17, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11e0496:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 17, 2020

Codecov Report

Merging #23360 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23360      +/-   ##
==========================================
+ Coverage   98.36%   98.40%   +0.04%     
==========================================
  Files         364      364              
  Lines        7279     7286       +7     
  Branches     1983     1983              
==========================================
+ Hits         7160     7170      +10     
+ Misses        119      116       -3     
Impacted Files Coverage Δ
components/modal/ActionButton.tsx 100.00% <100.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e7f3cc...11e0496. Read the comment docs.

@afc163 afc163 changed the title fix: modal confirm logic fix: Modal.info onOk execute times Apr 17, 2020
@afc163 afc163 marked this pull request as ready for review Apr 17, 2020
@afc163 afc163 merged commit f4c4895 into master Apr 17, 2020
31 checks passed
@afc163 afc163 deleted the fix-modal-confirm-logic branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants