Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Carousel keyboard behavior #23380

Merged
merged 1 commit into from Apr 18, 2020
Merged

fix: Carousel keyboard behavior #23380

merged 1 commit into from Apr 18, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 18, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23294

💡 Background and solution

https://codesandbox.io/s/charming-kilby-rtwt0?file=/index.js

📝 Changelog

Language Changelog
🇺🇸 English Fix Carousel tabbed Radio/Checkbox to non-active slide.
🇨🇳 Chinese 修复 Carousel 键盘切换到非活跃 slide 上的 Radio/Checkbox 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title fix: Carousel tabindex behavior in non-active slide fix: Carousel keyboard behavior Apr 18, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 18, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e04477:

Sandbox Source
antd reproduction template Configuration
ancient-worker-r0m6v PR

@codecov
Copy link

@codecov codecov bot commented Apr 18, 2020

Codecov Report

Merging #23380 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23380   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         364      364           
  Lines        7320     7320           
  Branches     1957     1994   +37     
=======================================
  Hits         7202     7202           
  Misses        118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ee966...4e04477. Read the comment docs.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4efc0bc:

Sandbox Source
antd reproduction template Configuration
zen-noyce-gzpwf PR

@afc163 afc163 merged commit 54d0503 into master Apr 18, 2020
32 checks passed
@afc163 afc163 deleted the fix-carousel branch Apr 18, 2020
@mendoncanorma
Copy link

@mendoncanorma mendoncanorma commented Apr 18, 2020

@afc163 ,
Can you please cherry pick this bug fix to antd 3.x. We are in mid of a project and can't upgrade to 4.x at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants