Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add dropdown group title rtl style #23404

Merged
merged 3 commits into from Apr 21, 2020
Merged

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 20, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

image

Description

  • 优化 site 中 下拉按钮样式,利于 RTL 展示
  • 可以看到 Dropdown group title 的 RTL 样式未设置,以前 Demo 中未列举该情况
  • Dropdown Demo 中 加入 group title 的 案例

After

image

image

📝 Changelog

Language Changelog
🇺🇸 English Add Dropdown group title RTL style
🇨🇳 Chinese 增加 Dropdown group title RTL 样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/dropdown/demo/sub-menu.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 20, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e3a30b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 20, 2020

Codecov Report

Merging #23404 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23404   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         364      364           
  Lines        7320     7320           
  Branches     2004     1957   -47     
=======================================
  Hits         7202     7202           
  Misses        118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43bc719...6e3a30b. Read the comment docs.

@@ -63,7 +63,7 @@ export default (props: SharedProps) => {
<DownOutlined
style={{
fontSize: '9px',
marginLeft: 2,
margin: '0 2px',
Copy link
Member

@afc163 afc163 Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

这里右边会多两像素的 padding。

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Apr 20, 2020

@xrkffgg xrkffgg requested a review from afc163 Apr 20, 2020
@afc163 afc163 merged commit 3d76859 into master Apr 21, 2020
31 checks passed
@afc163 afc163 deleted the fix-dropdown-group-title-rtl branch Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants