Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 💄 Divider support plain for lighter style #23405

Merged
merged 8 commits into from Apr 21, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 20, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

增加一个新的正文风格的分割文字风格,标题样式比较重,大多数场景都需要修改字体样式。

📝 Changelog

Language Changelog
🇺🇸 English Divider add plain prop which allows a non-heading style divider text.
🇨🇳 Chinese Divider 新增 plain 属性,可用于设置一个非标题样式的分割文字。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/divider/demo/customize-style.md
View rendered components/divider/demo/horizontal.md
View rendered components/divider/demo/no-heading.md
View rendered components/divider/demo/vertical.md
View rendered components/divider/demo/with-text.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 20, 2020

@afc163 afc163 changed the title feat: 💄 Divider support asHeading for lighter style feat: 💄 Divider support asHeading for lighter style Apr 20, 2020
@afc163 afc163 requested a review from zombieJ Apr 20, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80a83d2:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 changed the base branch from master to feature Apr 21, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 21, 2020

asHeading 这个不太符合现在的 api 风格,直接 heading or type='heading' 如何?

@afc163
Copy link
Member Author

@afc163 afc163 commented Apr 21, 2020

type 已经占用了用不了,heading 不明确。还有别的名字没。

@afc163 afc163 changed the title feat: 💄 Divider support asHeading for lighter style feat: 💄 Divider support plain for lighter style Apr 21, 2020
@afc163
Copy link
Member Author

@afc163 afc163 commented Apr 21, 2020

改成 plain 了。

@codecov
Copy link

@codecov codecov bot commented Apr 21, 2020

Codecov Report

Merging #23405 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23405   +/-   ##
========================================
  Coverage    98.48%   98.48%           
========================================
  Files          364      364           
  Lines         7314     7324   +10     
  Branches      2004     1998    -6     
========================================
+ Hits          7203     7213   +10     
  Misses         111      111           
Impacted Files Coverage Δ
components/upload/Upload.tsx 99.18% <ø> (ø)
components/config-provider/context.tsx 100.00% <100.00%> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (ø)
components/divider/index.tsx 100.00% <100.00%> (ø)
components/notification/index.tsx 96.77% <100.00%> (+0.14%) ⬆️
components/rate/index.tsx 100.00% <100.00%> (ø)
components/space/index.tsx 100.00% <100.00%> (ø)
components/typography/Base.tsx 100.00% <100.00%> (ø)
components/upload/UploadList.tsx 99.23% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c86aeb...80a83d2. Read the comment docs.

@@ -107,4 +92,10 @@
&-vertical&-dashed {
border-width: 0 0 0 1px;
}

&-heading&-with-text {
Copy link
Member

@zombieJ zombieJ Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-heading 是不是也要改改

@afc163 afc163 merged commit 1dab17e into feature Apr 21, 2020
30 checks passed
@afc163 afc163 deleted the feat-text-divider branch Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants