Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Typography support onEllipsis #23414

Merged
merged 3 commits into from Apr 21, 2020
Merged

feat: Typography support onEllipsis #23414

merged 3 commits into from Apr 21, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 20, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23188

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Typography ellipsis support onEllipsis event handler.
🇨🇳 Chinese Typography ellipsis 支持 onEllipsis事件。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/typography/demo/suffix.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 20, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d4605b:

Sandbox Source
antd reproduction template Configuration
Tooltip and Ellipsis Issue #23188

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1eb6c40:

Sandbox Source
antd reproduction template Configuration
Tooltip and Ellipsis Issue #23188

@codecov
Copy link

@codecov codecov bot commented Apr 20, 2020

Codecov Report

Merging #23414 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23414   +/-   ##
========================================
  Coverage    98.38%   98.38%           
========================================
  Files          364      364           
  Lines         7325     7327    +2     
  Branches      2008     2008           
========================================
+ Hits          7207     7209    +2     
  Misses         118      118           
Impacted Files Coverage Δ
components/typography/Base.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757c576...1eb6c40. Read the comment docs.

@dengfuping dengfuping merged commit 1d50004 into feature Apr 21, 2020
31 checks passed
@dengfuping dengfuping deleted the onEllipsis branch Apr 21, 2020
@afc163 afc163 mentioned this pull request Aug 9, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants