Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: first Divider render bug #23438

Merged
merged 1 commit into from Apr 21, 2020
Merged

fix: first Divider render bug #23438

merged 1 commit into from Apr 21, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 21, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23432

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the first Divider render differently with others.
🇨🇳 Chinese 修复第一个 Divider 渲染时样式不一致的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 merged commit 8bd8eee into master Apr 21, 2020
15 of 24 checks passed
@afc163 afc163 deleted the fix-divider-style branch Apr 21, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e7380f3:

Sandbox Source
antd reproduction template Configuration

@@ -9,7 +9,6 @@

background: @border-color-split;

&, /* for compatiable */
&-vertical {
position: relative;
top: -0.06em;
Copy link
Contributor

@JounQin JounQin Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask that what is top: -0.06em for? A comment here would be helpful. cc @afc163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants