Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ConfigProvider support config Input autoComplete #23455

Merged
merged 3 commits into from Apr 22, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 21, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23437

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ConfigProvider support input prop to config Input autoComplete.
🇨🇳 Chinese ConfigProvider 添加 input 属性以支持全局化配置 Input autoComplete 的默认值。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/config-provider/index.en-US.md
View rendered components/config-provider/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 21, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf0ccbf:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 21, 2020

Codecov Report

Merging #23455 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23455   +/-   ##
========================================
  Coverage    98.48%   98.48%           
========================================
  Files          364      364           
  Lines         7324     7328    +4     
  Branches      2009     2010    +1     
========================================
+ Hits          7213     7217    +4     
  Misses         111      111           
Impacted Files Coverage Δ
components/config-provider/context.tsx 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (ø)
components/input/Input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f467df5...bf0ccbf. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Apr 21, 2020

form 支持 autoComplete 的,是否已经能满足批量设置的需求了。

@afc163
Copy link
Member

@afc163 afc163 commented Apr 21, 2020

image

image

发现这个设计不错。

@fungjj92
Copy link

@fungjj92 fungjj92 commented Apr 21, 2020

Ooh, I'm really looking forward to this fix. Thanks for making it @zombieJ!

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 22, 2020

form 支持 autoComplete 的,是否已经能满足批量设置的需求了。

不是所有情况下,Input 都放在 form 里。另外,每个用到表单的页面都来个 autoComplete 不如全局一次性设置掉。

@afc163
Copy link
Member

@afc163 afc163 commented Apr 22, 2020

不在 form 里的 Input 不会生成 autoComplete 列表吧?

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 22, 2020

不在 form 里的 Input 不会生成 autoComplete 列表吧?

https://codesandbox.io/s/thirsty-gagarin-t6s6b?file=/src/App.js

第一个 Input 随便输入啥,回车。然后再在第二个输入框点一下。

@afc163
Copy link
Member

@afc163 afc163 commented Apr 22, 2020

name 是个麻烦事。

afc163
afc163 approved these changes Apr 22, 2020
@zombieJ zombieJ merged commit a1e0c41 into feature Apr 22, 2020
30 checks passed
@zombieJ zombieJ deleted the config-provider branch Apr 22, 2020
@suunryo
Copy link

@suunryo suunryo commented Jul 15, 2020

在DatePicker中的input也无效,这个太长的话,往往会遮挡住日期选框

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants