Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: select arrow won't rotate now #23468

Merged
merged 2 commits into from Apr 22, 2020
Merged

style: select arrow won't rotate now #23468

merged 2 commits into from Apr 22, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 22, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Select arrow won't rotate when open.
🇨🇳 Chinese Select 箭头打开时不再翻转。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 requested a review from zombieJ Apr 22, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 22, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b78302:

Sandbox Source
antd reproduction template Configuration

@@ -99,7 +99,7 @@
&-arrow {
.iconfont-mixin();
position: absolute;
top: 53%;
top: 50%;
Copy link
Member

@xrkffgg xrkffgg Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉 53 % 的 看着 更协调一些 😂

Copy link
Member Author

@afc163 afc163 Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

截个图来对比一下?

@codecov
Copy link

@codecov codecov bot commented Apr 22, 2020

Codecov Report

Merging #23468 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23468   +/-   ##
========================================
  Coverage    98.48%   98.48%           
========================================
  Files          364      364           
  Lines         7326     7326           
  Branches      2013     1965   -48     
========================================
  Hits          7215     7215           
  Misses         111      111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c07fc...6b78302. Read the comment docs.

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 22, 2020

1

image

2

image

@afc163 @yoyo837 看下 1、2 哪个更协调?

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 22, 2020

@zombieJ @AshoneA

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 22, 2020

2

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 22, 2020

先选择再看答案哦

答 案

2 是 53 %

我的选择是 2

@afc163
Copy link
Member Author

@afc163 afc163 commented Apr 22, 2020

先保持吧 53% 吧。

@afc163 afc163 merged commit 7935651 into feature Apr 22, 2020
22 of 26 checks passed
@afc163 afc163 deleted the style-select-arrow branch Apr 22, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 22, 2020

哈哈,原来已经做掉了。怪不得找了半天没发现旋转。

@ghostlhq
Copy link

@ghostlhq ghostlhq commented Apr 12, 2021

为啥要删了呢嘤嘤嘤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants