Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree custom icon missing when loading #23494

Merged
merged 1 commit into from Apr 22, 2020
Merged

fix: Tree custom icon missing when loading #23494

merged 1 commit into from Apr 22, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 22, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23470

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tree custom icon missing when node is loading data.
🇨🇳 Chinese 修复 Tree 自定义图标在加载状态下消失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

.@{tree-prefix-cls}-iconEle {
display: none;
}
}
Copy link
Member Author

@afc163 afc163 Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码不知道有什么用,删掉就好了。

@zombieJ 帮忙 comfirm 一下。

Copy link
Member

@zombieJ zombieJ Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来是没什么问题。

@@ -96,6 +96,10 @@
}
}
}

&-loading-icon {
color: @primary-color;
Copy link
Member Author

@afc163 afc163 Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

顺手把 loading icon 修正为 3.x 的主色。

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 22, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b8f9e6:

Sandbox Source
antd reproduction template Configuration
异步数据加载 - Ant Design Demo Issue #23470

@codecov
Copy link

@codecov codecov bot commented Apr 22, 2020

Codecov Report

Merging #23494 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23494      +/-   ##
==========================================
+ Coverage   98.47%   98.51%   +0.04%     
==========================================
  Files         363      363              
  Lines        7271     7271              
  Branches     1953     2002      +49     
==========================================
+ Hits         7160     7163       +3     
+ Misses        111      108       -3     
Impacted Files Coverage Δ
components/_util/openAnimation.tsx 96.42% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e877a...8b8f9e6. Read the comment docs.

@afc163 afc163 requested a review from zombieJ Apr 22, 2020
@zombieJ zombieJ merged commit 17f7e2f into master Apr 22, 2020
34 checks passed
@zombieJ zombieJ deleted the fix-tree-loading branch Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants