Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steps): Add flex on steps to fix ie11 #23561

Merged
merged 2 commits into from Apr 24, 2020
Merged

Conversation

AdrianoRuberto
Copy link
Contributor

@AdrianoRuberto AdrianoRuberto commented Apr 24, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#23453

馃挕 Background and solution

The problem is the flex default value on ie11 isn't the same as on chrome/ff. Setting flex: 1 0 auto; Make the Steps being displayed correctly.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English -
馃嚚馃嚦 Chinese -

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@AdrianoRuberto AdrianoRuberto changed the title Add flex on steps to fix ie11 fix(steps): Add flex on steps to fix ie11 Apr 24, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Apr 24, 2020

https://www.codefactor.io/repository/github/ant-design/ant-design/pull/23561

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 24, 2020

@afc163
Copy link
Member

@afc163 afc163 commented Apr 24, 2020

Could you help to update changelog here?

image

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9c560a8:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f96768e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 24, 2020

Codecov Report

Merging #23561 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23561   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         363      363           
  Lines        7267     7267           
  Branches     2002     1953   -49     
=======================================
  Hits         7158     7158           
  Misses        109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7cf20f1...f96768e. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Apr 24, 2020

Why closing?

@afc163 afc163 reopened this Apr 24, 2020
@afc163 afc163 merged commit 289dd08 into ant-design:master Apr 24, 2020
22 of 23 checks passed
@AdrianoRuberto
Copy link
Contributor Author

@AdrianoRuberto AdrianoRuberto commented Apr 24, 2020

This isn't working like it's supposed to

@AdrianoRuberto
Copy link
Contributor Author

@AdrianoRuberto AdrianoRuberto commented Apr 24, 2020

I thought adding flex: 1 0 auto at .steps-vertical would fix the problem, but it isn't the case.
I think I need to add it on ant-step-item instead but I need more time testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants