Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree with quick loadData frozen the virtual scroll #23581

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 25, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23569

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tree with virtual scroll frozen by quick loadData.
🇨🇳 Chinese 修复 Tree 使用虚拟滚动时会因为 loadData 更新过快而锁死的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 25, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d510119:

Sandbox Source
antd reproduction template Configuration
异步数据加载 - Ant Design Demo Issue #23569

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #23581 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23581   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         363      363           
  Lines        7267     7267           
  Branches     1953     1953           
=======================================
  Hits         7158     7158           
  Misses        109      109           
Impacted Files Coverage Δ
components/_util/motion.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50cc55...d510119. Read the comment docs.

@zombieJ zombieJ merged commit efbb284 into master Apr 25, 2020
@zombieJ zombieJ deleted the tree-load branch April 25, 2020 03:13
@wangdanting
Copy link

这个bug什么时候能够发版呀???

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 26, 2020

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree loadData 异步加载数据 虚拟滚动的高度计算错误导致目录树一部分被隐藏
4 participants