Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ConfigProvider getPopupContainer invalid #23594

Merged
merged 4 commits into from Apr 25, 2020
Merged

fix: ConfigProvider getPopupContainer invalid #23594

merged 4 commits into from Apr 25, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 25, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23446

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ConfigProvider getPopupContainer not working on DatePicker and Slider.
🇨🇳 Chinese 修复 ConfigProvider getPopupContainer 对 DatePicker 和 Slider 不生效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 25, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0cf6df6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 25, 2020

Codecov Report

Merging #23594 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23594      +/-   ##
==========================================
- Coverage   98.49%   98.46%   -0.03%     
==========================================
  Files         363      363              
  Lines        7239     7241       +2     
  Branches     1952     2003      +51     
==========================================
  Hits         7130     7130              
- Misses        109      111       +2     
Impacted Files Coverage Δ
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <100.00%> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <100.00%> (ø)
components/slider/index.tsx 100.00% <100.00%> (ø)
components/_util/openAnimation.tsx 85.71% <0.00%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f30a14...397c17e. Read the comment docs.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 397c17e:

Sandbox Source
antd reproduction template Configuration

@hengkx hengkx requested review from afc163, saeedrahimi and zombieJ and removed request for saeedrahimi Apr 25, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Apr 25, 2020

来个 test case?

@hengkx
Copy link
Member Author

@hengkx hengkx commented Apr 25, 2020

这个test写到哪 比较合适 组件里面 还是 config-provider 里面?

@afc163
Copy link
Member

@afc163 afc163 commented Apr 25, 2020

config-provider 里吧。

@zombieJ zombieJ merged commit 8cdf1c0 into master Apr 25, 2020
34 checks passed
@zombieJ zombieJ deleted the fix-23446 branch Apr 25, 2020
@hengkx hengkx mentioned this pull request Apr 25, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants