Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anchor regexp (#23577) #23595

Merged
merged 4 commits into from Apr 26, 2020
Merged

fix: anchor regexp (#23577) #23595

merged 4 commits into from Apr 26, 2020

Conversation

wuzekang
Copy link
Contributor

@wuzekang wuzekang commented Apr 25, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix fragment id regular expression
🇨🇳 Chinese 修复 fragment id 正则表达式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 25, 2020

@afc163
Copy link
Member

@afc163 afc163 commented Apr 25, 2020

最好能补上用例。

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97bc920:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 25, 2020

Codecov Report

Merging #23595 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23595      +/-   ##
==========================================
+ Coverage   98.49%   98.50%   +0.01%     
==========================================
  Files         363      363              
  Lines        7239     7239              
  Branches     1952     1952              
==========================================
+ Hits         7130     7131       +1     
+ Misses        109      108       -1     
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 94.61% <100.00%> (ø)
components/_util/openAnimation.tsx 96.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f30a14...97bc920. Read the comment docs.

@afc163 afc163 merged commit 4c9d038 into ant-design:master Apr 26, 2020
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants