Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input suffix align issue #23606

Merged
merged 1 commit into from
Apr 26, 2020
Merged

fix: Input suffix align issue #23606

merged 1 commit into from
Apr 26, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 26, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23588

💡 Background and solution

https://codesandbox.io/s/y0q37

📝 Changelog

Language Changelog
🇺🇸 English Fix Input with suffix align problem.
🇨🇳 Chinese 修复 Input 带 suffix 时的元素对齐问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 26, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8e36bb:

Sandbox Source
antd reproduction template Configuration
文本对齐 - Ant Design Demo PR

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #23606 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23606   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         363      363           
  Lines        7241     7241           
  Branches     1954     1992   +38     
=======================================
  Hits         7133     7133           
  Misses        108      108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c44c1...e8e36bb. Read the comment docs.

@afc163 afc163 merged commit 3ddc99c into master Apr 26, 2020
@afc163 afc163 deleted the fix-input-align branch April 26, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button element after Input (not inside) not getting aligned properly
2 participants