Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: List grid support more column count #23630

Merged
merged 8 commits into from Apr 27, 2020
Merged

feat: List grid support more column count #23630

merged 8 commits into from Apr 27, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 26, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23613
close #14407
close #21474

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English List grid support all column count like 5.
🇨🇳 Chinese List grid 支持所有分栏数字,比如分为 5 栏。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 26, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 39fa86b:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 changed the title [WIP] List grid support more number feat: List grid support more column count Apr 27, 2020
@afc163 afc163 requested review from zombieJ, hengkx and shaodahong Apr 27, 2020
@shaodahong
Copy link
Member

@shaodahong shaodahong commented Apr 27, 2020

image

有点不对劲

@codecov
Copy link

@codecov codecov bot commented Apr 27, 2020

Codecov Report

Merging #23630 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23630   +/-   ##
========================================
  Coverage    98.51%   98.51%           
========================================
  Files          363      363           
  Lines         7259     7269   +10     
  Branches      2004     1968   -36     
========================================
+ Hits          7151     7161   +10     
  Misses         108      108           
Impacted Files Coverage Δ
components/list/Item.tsx 100.00% <100.00%> (ø)
components/list/index.tsx 96.96% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae2b1f...39fa86b. Read the comment docs.

@afc163
Copy link
Member Author

@afc163 afc163 commented Apr 27, 2020

修好了。

Copy link
Member

@shaodahong shaodahong left a comment

LGTM

@afc163 afc163 merged commit 0534977 into feature Apr 27, 2020
31 of 32 checks passed
@afc163 afc163 deleted the feat-list-grid branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants