Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag support ref #23632

Merged
merged 3 commits into from Apr 27, 2020
Merged

feat: tag support ref #23632

merged 3 commits into from Apr 27, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 26, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

先把几个用了Wave的组件改一下,后面尝试重构Wave移除废弃的API

📝 Changelog

Language Changelog
🇺🇸 English fix Tag cannot be directly called by react-dnd
🇨🇳 Chinese 解决 Tag 无法直接被 react-dnd 调用的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 26, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d97f418:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #23632 into feature will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #23632      +/-   ##
===========================================
- Coverage    98.50%   98.50%   -0.01%     
===========================================
  Files          363      363              
  Lines         7245     7244       -1     
  Branches      2010     2010              
===========================================
- Hits          7137     7136       -1     
  Misses         108      108              
Impacted Files Coverage Δ
components/tag/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53329a...7267509. Read the comment docs.

@hengkx hengkx changed the title [WIP]feat: tag support ref feat: tag support ref Apr 27, 2020
@hengkx hengkx requested review from zombieJ, afc163 and chenshuai2144 and removed request for zombieJ and afc163 Apr 27, 2020
@zombieJ zombieJ merged commit 8ae2b1f into feature Apr 27, 2020
16 checks passed
@zombieJ zombieJ deleted the feat/tag-ref branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants