Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve caret position馃悰 #23633

Merged
merged 5 commits into from Apr 27, 2020
Merged

Conversation

huntdream
Copy link
Contributor

@huntdream huntdream commented Apr 26, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #23524
ref: #15173

馃挕 Background and solution

The caret in Password component will move to the start position of text after change display mode

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix Password caret position
馃嚚馃嚦 Chinese 淇Password缁勪欢杈撳叆鍏夋爣浣嶇疆

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 26, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 47c841f:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 26, 2020

Codecov Report

Merging #23633 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23633      +/-   ##
==========================================
- Coverage   98.50%   98.46%   -0.05%     
==========================================
  Files         363      363              
  Lines        7209     7211       +2     
  Branches     2000     1952      -48     
==========================================
- Hits         7101     7100       -1     
- Misses        108      111       +3     
Impacted Files Coverage 螖
components/input/Password.tsx 97.50% <100.00%> (+0.13%) 猬嗭笍
components/_util/openAnimation.tsx 85.71% <0.00%> (-10.72%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dabec4c...47c841f. Read the comment docs.

@yoyo837 yoyo837 changed the title 馃悰 fix: preserve caret position fix: 馃悰 preserve caret position Apr 27, 2020
@yoyo837 yoyo837 changed the title fix: 馃悰 preserve caret position fix: preserve caret position馃悰 Apr 27, 2020
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 27, 2020

鑳藉姞涓涓猼est case 鍒ゆ柇涓嬪厜鏍囧湪涓嶅湪鍘熶綅缃悧锛

@huntdream
Copy link
Contributor Author

@huntdream huntdream commented Apr 27, 2020

鑳藉姞涓涓猼est case 鍒ゆ柇涓嬪厜鏍囧湪涓嶅湪鍘熶綅缃悧锛

娌℃湁鍐嶅彟澶栧啓涓涓猼est case锛屽湪should keep focus state閲岄潰鐘舵佸彉鎹㈠墠鍚庢坊鍔犱簡鍒ゆ柇
(涔嬪墠娌℃庝箞鍐欒繃娴嬭瘯锛屼笉鐭ラ亾杩欐牱瀵逛笉瀵 馃槀 )

@afc163 afc163 merged commit e199a7a into ant-design:master Apr 27, 2020
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants