Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Table summary support fixed columns #23647

Merged
merged 3 commits into from Apr 27, 2020
Merged

feat: Table summary support fixed columns #23647

merged 3 commits into from Apr 27, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 27, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #19769

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Table summary support fixed columns.
🇨🇳 Chinese Table summary 支持固定列。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/summary.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 27, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d8b146:

Sandbox Source
antd reproduction template Configuration
modest-framework-kqwqo Issue #19769

@codecov
Copy link

@codecov codecov bot commented Apr 27, 2020

Codecov Report

Merging #23647 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23647   +/-   ##
========================================
  Coverage    98.51%   98.51%           
========================================
  Files          363      363           
  Lines         7259     7260    +1     
  Branches      2004     1965   -39     
========================================
+ Hits          7151     7152    +1     
  Misses         108      108           
Impacted Files Coverage Δ
components/table/Table.tsx 99.23% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8934bbf...ecbb22d. Read the comment docs.

<td colSpan={2}>
<Text type="danger">{totalBorrow - totalRepayment}</Text>
</td>
</tr>
Copy link
Member

@afc163 afc163 Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来的写法也迁移掉吧,让用户学一套就够了。

@zombieJ zombieJ requested a review from afc163 Apr 27, 2020
});

return (
<>
Copy link
Member

@afc163 afc163 Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不要把 <Table.Summary> 干脆也用上?

Copy link
Member Author

@zombieJ zombieJ Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先留着,有拓展需求的时候再上。免得没用处太早上,以后要用了发现少一个组件名。

afc163
afc163 approved these changes Apr 27, 2020
@zombieJ zombieJ merged commit 2da7e29 into feature Apr 27, 2020
30 of 31 checks passed
@zombieJ zombieJ deleted the table-fixed branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants