Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table pagination position ts typo #23681

Merged
merged 2 commits into from Apr 27, 2020
Merged

fix: Table pagination position ts typo #23681

merged 2 commits into from Apr 27, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 27, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

ref #23656

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix: Table pagination posstion ts typo
馃嚚馃嚦 Chinese 淇Table pagination position Typescript瀹氫箟閿欒

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 27, 2020

@hengkx hengkx changed the title fix: Table pagination posstion ts typo fix: Table pagination position ts typo Apr 27, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8d89081:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 27, 2020

Codecov Report

Merging #23681 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23681   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         363      363           
  Lines        7199     7199           
  Branches     2000     2000           
=======================================
  Hits         7091     7091           
  Misses        108      108           
Impacted Files Coverage 螖
components/table/hooks/usePagination.ts 100.00% <酶> (酶)
components/pagination/Pagination.tsx 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5f1d5a1...8d89081. Read the comment docs.

@afc163 afc163 merged commit a9d4459 into master Apr 27, 2020
33 of 34 checks passed
@afc163 afc163 deleted the fix/table-ts branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants