Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table filter dropdown in rtl #23695

Merged
merged 1 commit into from Apr 28, 2020
Merged

fix: table filter dropdown in rtl #23695

merged 1 commit into from Apr 28, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

RTL 下,从左侧调整为右侧

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Table filter dropdown position in RTL
🇨🇳 Chinese 修复 Table filter 下拉框在 RTL 下的位置

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 28, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d234e2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 28, 2020

Codecov Report

Merging #23695 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23695   +/-   ##
=======================================
  Coverage   98.49%   98.50%           
=======================================
  Files         363      363           
  Lines        7199     7201    +2     
  Branches     1952     2001   +49     
=======================================
+ Hits         7091     7093    +2     
  Misses        108      108           
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 96.15% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5183592...0d234e2. Read the comment docs.

@afc163 afc163 merged commit 156ff76 into master Apr 28, 2020
31 checks passed
@afc163 afc163 deleted the fix-table-filter-dropdown-rtl branch Apr 28, 2020
@pr-triage pr-triage bot added the PR: merged label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants