Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooltip): rewrite with hook #23699

Merged
merged 12 commits into from
May 15, 2020
Merged

refactor(tooltip): rewrite with hook #23699

merged 12 commits into from
May 15, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor with hook
🇨🇳 Chinese 用 react hook 重构

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

tests-checker[bot]
tests-checker bot suggested changes Apr 28, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 28, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 28, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d669afe:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 28, 2020 •
edited
Loading

Codecov Report

Merging #23699 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23699      +/-   ##
==========================================
- Coverage   98.82%   98.82%   -0.01%     
==========================================
  Files         364      364              
  Lines        7293     7291       -2     
  Branches     2019     2020       +1     
==========================================
- Hits         7207     7205       -2     
  Misses         86       86
Impacted Files Coverage Δ
components/slider/index.tsx 100.00% <ø> (ø)
components/slider/SliderTooltip.tsx 96.66% <100.00%> (+1.42%) ⬆️
components/tooltip/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9559754...6f08003. Read the comment docs.

@hengkx hengkx changed the title refactor(tooltip): rewrite with hook [WIP]refactor(tooltip): rewrite with hook May 2, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label May 2, 2020
@afc163
Copy link
Member

afc163 commented May 7, 2020

/rebase

@hengkx
Copy link
Member Author

hengkx commented May 10, 2020

/rebase

@hengkx hengkx changed the title [WIP]refactor(tooltip): rewrite with hook refactor(tooltip): rewrite with hook May 10, 2020
@hengkx
Copy link
Member Author

hengkx commented May 15, 2020

/rebase

@hengkx hengkx requested a review from saeedrahimi May 15, 2020 00:36
@afc163 afc163 merged commit f90702c into master May 15, 2020
@afc163 afc163 deleted the refactor/tooltip branch May 15, 2020 02:47
@afc163 afc163 mentioned this pull request May 16, 2020
Merged
@xrkffgg xrkffgg mentioned this pull request Jul 30, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker tests-checker requested changes

@zombieJ zombieJ Awaiting requested review from zombieJ

@afc163 afc163 Awaiting requested review from afc163

@yoyo837 yoyo837 Awaiting requested review from yoyo837

@AshoneA AshoneA Awaiting requested review from AshoneA

@saeedrahimi saeedrahimi Awaiting requested review from saeedrahimi

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Refactor with React Hooks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hengkx @ant-design-bot @afc163 @zombieJ