Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct Button type="danger" TypeScript definition #23709

Merged
merged 4 commits into from Apr 28, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close #23708
close #23697

📝 Changelog

Language Changelog
🇺🇸 English Remove Button deprecated type="danger" TypeScript definition and warn it.
🇨🇳 Chinese 移除已废弃的 Button type="danger" TypeScript 定义并增加警告信息。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title chore: correct Button type="dark" TypeScript definition fix: correct Button type="dark" TypeScript definition Apr 28, 2020
@afc163 afc163 changed the title fix: correct Button type="dark" TypeScript definition fix: correct Button type="danger" TypeScript definition Apr 28, 2020
@afc163 afc163 changed the title fix: correct Button type="danger" TypeScript definition fix: correct Button type="danger" TypeScript definition Apr 28, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 28, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 67d44c3:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 91393d6:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 merged commit c3c2c15 into master Apr 28, 2020
20 of 27 checks passed
@afc163 afc163 deleted the tsd-button-type branch Apr 28, 2020
@brucejcw
Copy link

@brucejcw brucejcw commented Nov 12, 2020

what is the purpose to remove 'danger'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants