Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table should not crash pageSize is undefined #23724

Merged
merged 3 commits into from Apr 28, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23722

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table crash when pageSize is undefined.
🇨🇳 Chinese 修复 Table 在 pageSize 是 undefined 时崩溃的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 28, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 950b753:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4a993e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 28, 2020

Codecov Report

Merging #23724 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23724   +/-   ##
=======================================
  Coverage   98.52%   98.53%           
=======================================
  Files         363      363           
  Lines        7202     7211    +9     
  Branches     1953     2004   +51     
=======================================
+ Hits         7096     7105    +9     
  Misses        106      106           
Impacted Files Coverage Δ
components/table/hooks/usePagination.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7790046...c4a993e. Read the comment docs.

@zombieJ zombieJ merged commit 53a76f0 into master Apr 28, 2020
33 checks passed
@zombieJ zombieJ deleted the fix-table-pagination branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants