-
-
Notifications
You must be signed in to change notification settings - Fork 48.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Table should not crash pageSize is undefined #23724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 950b753:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c4a993e:
|
Codecov Report
@@ Coverage Diff @@
## master #23724 +/- ##
=======================================
Coverage 98.52% 98.53%
=======================================
Files 363 363
Lines 7202 7211 +9
Branches 1953 2004 +51
=======================================
+ Hits 7096 7105 +9
Misses 106 106
Continue to review full report at Codecov.
|
🤔 This is a ...
🔗 Related issue link
fix #23722
💡 Background and solution
📝 Changelog
pageSize
isundefined
.pageSize
是undefined
时崩溃的问题。☑️ Self Check before Merge