Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ConfigProvider support getTargetContainer #23751

Merged
merged 7 commits into from Apr 29, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 29, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23626

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ConfigProvider support getTargetContainer to config Affix target props.
🇨🇳 Chinese ConfigProvider 支持 getTargetContainer 以配置 Affix target 属性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Apr 29, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 29, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 728fa1c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 29, 2020

Codecov Report

Merging #23751 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23751   +/-   ##
========================================
  Coverage    98.53%   98.53%           
========================================
  Files          363      364    +1     
  Lines         7247     7255    +8     
  Branches      2007     2021   +14     
========================================
+ Hits          7141     7149    +8     
  Misses         106      106           
Impacted Files Coverage Δ
components/config-provider/context.tsx 100.00% <ø> (ø)
components/affix/index.tsx 99.13% <100.00%> (+0.04%) ⬆️
components/anchor/Anchor.tsx 94.57% <100.00%> (-0.05%) ⬇️
components/anchor/AnchorLink.tsx 100.00% <100.00%> (ø)
components/anchor/context.ts 100.00% <100.00%> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f347ec...728fa1c. Read the comment docs.

@zombieJ zombieJ marked this pull request as ready for review Apr 29, 2020
@zombieJ zombieJ merged commit bb1f157 into feature Apr 29, 2020
32 checks passed
@zombieJ zombieJ deleted the getTargetContainer branch Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants