Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: optimize button loading style in rtl #23776

Merged
merged 3 commits into from May 2, 2020
Merged

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 30, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

补充 #23783

📝 Changelog

Language Changelog
🇺🇸 English Optimize Button loading style in RT
🇨🇳 Chinese 优化 Button loading 状态在 RTL 下样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 30, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

if (existIcon) {
return (
<span className={`${prefixCls}-loading-icon`}>
<LoadingOutlined />
<LoadingOutlined style={iconStyle} />
Copy link
Member

@afc163 afc163 Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon 有个 rotate 属性。

Copy link
Member Author

@xrkffgg xrkffgg Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我试了,那个是 rotate ,我这里用了 rotateY

@afc163
Copy link
Member

@afc163 afc163 commented Apr 30, 2020

加个测试用例。

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Apr 30, 2020

#23783 这个把 padding 放到里面, 我这就不能用 rotateY 了。

感觉只有 新增一个 loading 逆时针的 icon 才行了啊

@xrkffgg xrkffgg changed the title style: optimize button loading style in rtl [WIP] style: optimize button loading style in rtl Apr 30, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 30, 2020

Codecov Report

Merging #23776 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23776      +/-   ##
==========================================
- Coverage   98.54%   98.53%   -0.01%     
==========================================
  Files         364      364              
  Lines        7261     7260       -1     
  Branches     2022     1975      -47     
==========================================
- Hits         7155     7154       -1     
  Misses        106      106              
Impacted Files Coverage Δ
components/button/LoadingIcon.tsx 100.00% <100.00%> (ø)
components/menu/index.tsx 99.13% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7139493...bee533f. Read the comment docs.

@xrkffgg xrkffgg changed the title [WIP] style: optimize button loading style in rtl style: optimize button loading style in rtl May 1, 2020
@xrkffgg xrkffgg merged commit bd692be into master May 2, 2020
20 of 27 checks passed
@xrkffgg xrkffgg deleted the opt-btn-loading-rtl branch May 2, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants