style: optimize button loading style in rtl #23776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
afc163
reviewed
Apr 30, 2020
components/button/LoadingIcon.tsx
Outdated
| if (existIcon) { | ||
| return ( | ||
| <span className={`${prefixCls}-loading-icon`}> | ||
| <LoadingOutlined /> | ||
| <LoadingOutlined style={iconStyle} /> |
There was a problem hiding this comment.
我试了，那个是 rotate ，我这里用了 rotateY
|
加个测试用例。 |
xrkffgg
force-pushed
the
opt-btn-loading-rtl
branch
from
c8692fb
to
76bc6f1
Compare
|
#23783 这个把 padding 放到里面， 我这就不能用 rotateY 了。 感觉只有 新增一个 loading 逆时针的 icon 才行了啊 |
xrkffgg
changed the title
Codecov Report
@@ Coverage Diff @@
## master #23776 +/- ##
==========================================
- Coverage 98.54% 98.53% -0.01%
==========================================
Files 364 364
Lines 7261 7260 -1
Branches 2022 1975 -47
==========================================
- Hits 7155 7154 -1
Misses 106 106
Continue to review full report at Codecov.
|
xrkffgg
changed the title
xrkffgg
force-pushed
the
opt-btn-loading-rtl
branch
from
de183d7
to
bee533f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
补充 #23783
📝 Changelog
☑️ Self Check before Merge