Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: fix Button loading not smooth #23783

Merged
merged 1 commit into from Apr 30, 2020
Merged

improvement: fix Button loading not smooth #23783

merged 1 commit into from Apr 30, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Apr 30, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Resolve #23780

Before:

Kapture 2020-04-30 at 16 55 11

After:

Kapture 2020-04-30 at 16 54 30

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix Button loading animation
馃嚚馃嚦 Chinese 淇 Button loading 鍔ㄧ敾

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@shaodahong shaodahong changed the title improve: fix Button loading not smooth improvement: fix Button loading not smooth Apr 30, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 30, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa5a583:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 30, 2020

Codecov Report

Merging #23783 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23783   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         364      364           
  Lines        7258     7258           
  Branches     1974     1974           
=======================================
  Hits         7152     7152           
  Misses        106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0b5d09d...fa5a583. Read the comment docs.

@afc163 afc163 merged commit e34fc4a into ant-design:master Apr 30, 2020
22 checks passed
@shaodahong shaodahong deleted the improve-button-loading branch Apr 30, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
@Loving-Vincent
Copy link

@Loving-Vincent Loving-Vincent commented May 20, 2020

windows鐜涓嬩緷鏃у崱椤匡紝loading鏃秈con鏄獊鐒跺脊鍑烘潵鐨勶紝鍜屼笂闈if涓殑鏁堟灉涓嶄竴鏍枫瀹樼綉Demo鍙互澶嶇幇銆

button

Environment Info
Windows 10
Chrome 81.0

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented May 20, 2020

windows鐜涓嬩緷鏃у崱椤匡紝loading鏃秈con鏄獊鐒跺脊鍑烘潵鐨勶紝鍜屼笂闈if涓殑鏁堟灉涓嶄竴鏍枫瀹樼綉Demo鍙互澶嶇幇銆

button

Environment Info
Windows 10
Chrome 81.0

鎵嬩笂鏆傛椂娌℃湁 win 鐨勬満鍣紝楹荤儲鐪嬩笅4.2.1 杩欎釜鐗堟湰鏈夐棶棰樹箞

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented May 20, 2020

Kapture 2020-05-20 at 20 26 19

@Loving-Vincent 鐢ㄨ櫄鎷熸満鐨 Windows 璇曚簡涓嬪彂鐜 4.2.1 鐨勭増鏈槸濂界殑锛屽彲鑳芥槸鍚庨潰鐨勬敼鍧忎簡锛岄渶瑕佹帓鏌ヤ笅

@Loving-Vincent
Copy link

@Loving-Vincent Loving-Vincent commented May 20, 2020

鍡棷锛4.2.1鐗堟湰鏄甯哥殑銆傛垜鍏堥鍥炶繖涓増鏈

@Loving-Vincent
Copy link

@Loving-Vincent Loving-Vincent commented May 20, 2020

鍡棷锛4.2.1鐗堟湰鏄甯哥殑銆傛垜鍏堥鍥炶繖涓増鏈

4.2.1鐗堟湰濂藉儚鏈塨ug锛屾崲涓婁簡4.2.2鐗堟湰锛屾病鏈夊崱椤块棶棰樹簡馃槂

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented May 20, 2020

鍡棷锛4.2.1鐗堟湰鏄甯哥殑銆傛垜鍏堥鍥炶繖涓増鏈

4.2.1鐗堟湰濂藉儚鏈塨ug锛屾崲涓婁簡4.2.2鐗堟湰锛屾病鏈夊崱椤块棶棰樹簡馃槂

浠涔 bug锛屽彲浠ュ湪杩欓噷璁ㄨ #24323

@Loving-Vincent
Copy link

@Loving-Vincent Loving-Vincent commented May 20, 2020

鎴戝湪antd鐨刧ithub releases閲岄潰鐪嬪埌鐨勶紝瀹夎4.2.1鐗堟湰鏃朵細鎶ラ敊锛屽湪4.2.2鐗堟湰涓慨澶嶄簡銆

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 20, 2020

鎴戝湪antd鐨刧ithub releases閲岄潰鐪嬪埌鐨勶紝瀹夎4.2.1鐗堟湰鏃朵細鎶ラ敊锛屽湪4.2.2鐗堟湰涓慨澶嶄簡銆

鍜岃鍔熻兘娌℃湁鍏崇郴銆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants