-
-
Notifications
You must be signed in to change notification settings - Fork 48.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MenuItem support danger
#23785
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 608e5d4:
|
#22758 之后在其他 PR 里搞一下。 |
单独一个属性不考虑以后的扩展吗? 万一以后又来了success fail之类的怎么办。 |
MenuItem 的属性应该比较纯粹,不会有太多状态。 |
Codecov Report
@@ Coverage Diff @@
## feature #23785 +/- ##
========================================
Coverage 98.45% 98.45%
========================================
Files 364 364
Lines 7259 7259
Branches 2012 2023 +11
========================================
Hits 7147 7147
Misses 112 112
Continue to review full report at Codecov.
|
对比一下,普通的 hover 是不是有点淡了 |
嗯,在和设计师对一下。看看需不需要拓展。 |
和设计师对了一下,暂时只需要 danger 就够了。有需求以后再加。 |
🤔 This is a ...
🔗 Related issue link
resolve #23663
💡 Background and solution
Preview: https://preview-23785-ant-design.surge.sh/components/dropdown-cn/#components-dropdown-demo-basic
📝 Changelog
danger
prop.danger
属性。☑️ Self Check before Merge
View rendered components/dropdown/demo/basic.md
View rendered components/menu/demo/theme.md
View rendered components/menu/index.en-US.md
View rendered components/menu/index.zh-CN.md