Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MenuItem support danger #23785

Merged
merged 6 commits into from Apr 30, 2020
Merged

feat: MenuItem support danger #23785

merged 6 commits into from Apr 30, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 30, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23663

💡 Background and solution

Preview: https://preview-23785-ant-design.surge.sh/components/dropdown-cn/#components-dropdown-demo-basic

📝 Changelog

Language Changelog
🇺🇸 English Menu.Item support danger prop.
🇨🇳 Chinese Menu.Item 支持 danger 属性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/dropdown/demo/basic.md
View rendered components/menu/demo/theme.md
View rendered components/menu/index.en-US.md
View rendered components/menu/index.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Apr 30, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 30, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 608e5d4:

Sandbox Source
antd reproduction template Configuration

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 30, 2020

#22758 之后在其他 PR 里搞一下。

@zombieJ zombieJ marked this pull request as ready for review Apr 30, 2020
@ztplz
Copy link
Contributor

@ztplz ztplz commented Apr 30, 2020

单独一个属性不考虑以后的扩展吗? 万一以后又来了success fail之类的怎么办。

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 30, 2020

单独一个属性不考虑以后的扩展吗? 万一以后又来了success fail之类的怎么办。

MenuItem 的属性应该比较纯粹,不会有太多状态。

@zombieJ zombieJ requested a review from afc163 Apr 30, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 30, 2020

Codecov Report

Merging #23785 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23785   +/-   ##
========================================
  Coverage    98.45%   98.45%           
========================================
  Files          364      364           
  Lines         7259     7259           
  Branches      2012     2023   +11     
========================================
  Hits          7147     7147           
  Misses         112      112           
Impacted Files Coverage Δ
components/menu/MenuItem.tsx 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e183e...608e5d4. Read the comment docs.

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 30, 2020

对比一下,普通的 hover 是不是有点淡了

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 30, 2020

要不要再加一个 primary 的 和 danger 对应

效果和 github 的一样

image

afc163
afc163 approved these changes Apr 30, 2020
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 30, 2020

嗯,在和设计师对一下。看看需不需要拓展。

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 30, 2020

和设计师对了一下,暂时只需要 danger 就够了。有需求以后再加。

@zombieJ zombieJ merged commit 9823238 into feature Apr 30, 2020
32 checks passed
@zombieJ zombieJ deleted the menu-danger branch Apr 30, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants