-
-
Notifications
You must be signed in to change notification settings - Fork 50.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ㊙️ Input passowrd custom icon #23792
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 68a8cdd:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
点击后 变色,这是新加的吗? 😂 |
仔细看 demo 代码。 |
<Input.Password placeholder="input password" /> | ||
<Input.Password | ||
placeholder="input password" | ||
iconRender={visible => (visible ? <EyeTwoTone /> : <EyeInvisibleOutlined />)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EyeTwoTone 自带颜色。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 没注意这块
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IconRender does give an error saying its not a property for <Input.Password>
However the VisibilityToggle does work. Can someone please address this.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b3fc7a6:
|
Codecov Report
@@ Coverage Diff @@
## feature #23792 +/- ##
========================================
Coverage 98.45% 98.45%
========================================
Files 364 364
Lines 7259 7261 +2
Branches 2022 2024 +2
========================================
+ Hits 7147 7149 +2
Misses 112 112
Continue to review full report at Codecov.
|
🤔 This is a ...
🔗 Related issue link
close #23778
💡 Background and solution
Also resolve #23484 and #15369
📝 Changelog
iconRender
prop.iconRender
属性用于自定义切换图标☑️ Self Check before Merge