Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds default English localisations for Form. #23859

Merged
merged 2 commits into from May 7, 2020
Merged

feat: Adds default English localisations for Form. #23859

merged 2 commits into from May 7, 2020

Conversation

mjfwebb
Copy link
Contributor

@mjfwebb mjfwebb commented May 4, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#23369

馃挕 Background and solution

Adds missing localisations to the default localisation file. These were already present in zh_CN.tsx.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Adds default en localisations
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@mjfwebb mjfwebb changed the title Adds default English localisations for Form. feat: Adds default English localisations for Form. May 4, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 4, 2020

@yoyo837
Copy link
Contributor

yoyo837 commented May 7, 2020

CI failed.

@mjfwebb
Copy link
Contributor Author

mjfwebb commented May 7, 2020

@yoyo837 What do I need to change to get CI to succeed? The errors seem unrelated to this PR.

@yoyo837
Copy link
Contributor

yoyo837 commented May 7, 2020

Pls rebase and run npm run test -- -u, than push all changes.

Rebase to ant-design/ant-design/master
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df4456a:

Sandbox Source
antd reproduction template Configuration

yoyo837
yoyo837 approved these changes May 7, 2020
@afc163 afc163 merged commit d643d11 into ant-design:master May 7, 2020
20 checks passed
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants