feat: dropdown support arrow #23869

wzhudev · 2020-05-05T05:38:02Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	Dropdown component support `arrow` prop
🇨🇳 Chinese	Dropdown 组件支持下拉框箭头

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

View rendered components/dropdown/index.en-US.md
View rendered components/dropdown/index.zh-CN.md

ant-design-bot · 2020-05-05T05:41:42Z

codesandbox-ci · 2020-05-05T05:44:53Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 82a7d31:

Sandbox	Source
antd reproduction template	Configuration

afc163 · 2020-05-05T05:55:37Z

feature branch

wzhudev · 2020-05-05T07:58:13Z

How could I fix the snapshot?

It looks good on my laptop (WSL):

afc163 · 2020-05-06T02:59:02Z

/rebase

wzhudev · 2020-05-06T04:52:03Z

@afc163 Bundle size budget of the dark mode CSS is exceeded. Shall I increase the budget?

components/dropdown/style/index.less

afc163 · 2020-05-16T09:05:09Z

ping

wzhudev · 2020-05-16T23:54:43Z

ping

I was occupied by my dissertation works recently. I am able to finish this PR tomorrow. :)

afc163 · 2020-05-21T05:55:31Z

conflicted

wzhudev · 2020-05-22T00:49:17Z

@afc163 Done. Just the bundle size thing.

afc163 · 2020-05-22T03:17:30Z

需要加个例子：https://preview-23869-ant-design.surge.sh/components/dropdown-cn/

放在第三个。

afc163 · 2020-05-22T03:18:05Z

这里的样式有问题。

afc163 · 2020-05-28T15:02:58Z

@wendellhu95 Any chance to finish this before end of May?

wzhudev · 2020-05-28T23:24:06Z

@wendellhu95 Any chance to finish this before end of May?

I was blocked by the antd-tools problem (using Windows). So I installed the Elementary OS to avoid that problem. Hopefully I can complete this PR in two or three days.

codecov · 2020-05-29T02:05:43Z

Codecov Report

Merging #23869 into feature will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           feature   #23869   +/-   ##
========================================
  Coverage    99.22%   99.22%           
========================================
  Files          365      365           
  Lines         7310     7310           
  Branches      1993     2045   +52     
========================================
  Hits          7253     7253           
  Misses          57       57

Impacted Files	Coverage Δ
components/dropdown/dropdown.tsx	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d154435...82a7d31. Read the comment docs.

close #22758

ant-design-bot · 2020-06-05T00:23:57Z

wzhudev · 2020-06-05T06:17:25Z

@afc163. Sorry for the delay. Please check.

afc163 · 2020-06-05T06:17:40Z

components/dropdown/demo/arrow.md

+
+## zh-CN
+
+asd 可以展示一个箭头。


Suggested change

asd 可以展示一个箭头。

可以展示一个箭头。

afc163 · 2020-06-05T06:18:16Z

components/dropdown/demo/arrow.md

+  </Dropdown>,
+  mountNode,
+);
+```


这个例子把所有的方向都展示一下，顺序放在 placement.md 后面。

afc163 · 2020-06-05T10:52:32Z

components/dropdown/demo/arrow.md

-      Hover Me <DownOutlined />
-    </a>
-  </Dropdown>,
+  <div>


Suggested change

<div>

<>

* feat: add successColor for Progress (#24655) * feat: add successColor for Progress * feat: update * fix: update test * remove snap * feat: add test case * refactor success * feat: adjust styyle * feat: add DevWarning * feat: Support rowSelection.dirty (#24718) * feat: Support rowSelection.dirty * rename to reserveKeys * preserveKeys will keep record also * to preserveSelectedRowKeys * feat: add ghost prop for collapse (#24734) * feat: add ghost prop for collapse * doc: version of collapse's ghost prop * refactor: make ghost collapse's less code to a nested style * chore: remove redundant codes in ghost collapse's less & doc * doc: add a background wrapper for ghost collapse demo * doc: dark-theme wrapper bg-color for ghost collapse demo * test: update snapshot of ghost collapse * doc: use softer bg-color on ghost collapse demo * doc: remove disabled panel in ghost collapse demo * feat: form instance support getFieldInstance (#24711) * support getFieldInstance * update doc * fix lint * move func * move into hooks * update ref logic * fix lint * rm only * fix docs * feat: dropdown support arrow (#23869) * feat: dropdown support arrow prop close #22758 * test: update snapshot * fix: fix dropdown cls names * test: update snapshot * test: update snapshot * doc: update demo * test: update demo snapshot * demo * fix: snapshot * chore: change the style of ghost collapse & demo modified (#24762) * refactor: reduce content padding in ghost collapse * doc: remove the wrapper outside ghost collapse Designer want the demo differs from other demos * refactor: remove redundant .less code in collapse * feat: cascader dropdown-render prop (#24812) * feat: cascader dropdown-render prop * fix: update Cascader dropdownRender type annotation * fix: set rc-cascader semver from ^ to ~ * docs: fix coding style in cascader/custom-dropdown * feat: 🆕 support Drawer closeIcon (#24842) * feat: 🆕 support Drawer closeIcon close #19283 close #19153 * add test case * update docs * feat: 🆕 Cascader expandIcon (#24865) * feat: cascader expandIcon * fix: snap * refactor: reduce CSS size (#24846) * refactor: reduce button css size * refactor: remove redundant button .less code * feat: add Table onChange an action param (#24697) * Working on tests * created TableAction type * changed TableActions to tuple * removed chinese documentation line * refactor TableActions * fix documentation * Moved action into extra param * minor doc change * feat: add closeIcon customize tag close (#24885) * feat: add closeIcon customize tag close * docs fix * update snap * fix: css name * update snapshot * snapshot * feat: add radio `optionType` api to set radio option type (#24809) * feat: radio component * docs: update md * fix: snap * test components * fix: use optionType * fix name * add warning * fix * feat: expand rate character (#24903) * feat: expand rate character * fix: demo * fix: snap * Update components/rate/index.zh-CN.md Co-authored-by: 偏右 <afc163@gmail.com> * fix Co-authored-by: 偏右 <afc163@gmail.com> * Refactor demo code box actions (#24887) * refactor: refine the styling of actions part of demo code-box * fix: lint style * refactor: move Result children to end (#24945) * feat: remove content max-width on dot-step (#24907) * feat: add Skeleton-Image (#24805) * feat: add Skeleton-Image * feat: add docs * fix: adjust skeleton * feat: adjust Image Component * feat: rebase * feat: adjust style * fix: lint * feat: remove size * feat: delete md * feat: fix style * ✨ feat: Mentions support autoSize (#24961) close #17746 * chore: replace textarea with rc-textarea (#24966) * feat: update pagination@2.3.0 support onChange called when pageSize change (#24964) * feat: update pagination@2.5.0 and add test case to relative component * fix: lint * delete * feat: add test case for pagination * adjust test case * feat: Implement centered prop in Tabs (#24958) * Implement centered in Tabs along with its tests and docs * Fix build error * Add Chinese translations and remove test case Co-authored-by: Ashkan Pourghasem <ashkan.pourghasem@gmail.com> * feat: Add modal style parameter (#24773) * add some paramters in default.less * Update components/style/themes/default.less Co-authored-by: Amumu <yoyo837@hotmail.com> * change parameter in compact.less Co-authored-by: Crystal Gao <jinggao@ebay.com> Co-authored-by: Amumu <yoyo837@hotmail.com> * feat: export Tabs addIcon (#25006) * feat: export Tabs addIcon * update snapshot * feat: showNow on timepicker and datetimepicker (#25032) * feat: update rc-picker@1.7.1 and fix icons of month and quarter picker in DatePicker Component (#25035) * feat: update rc-picker@1.7.1 * delete * add * feat: expand rate support props (#24993) * docs: 📝 Add Form.Item hidden in doc (#25108) close #25101 * fix: ⌨️ Improve Pagination accessibility issue (#25119) * ⌨️ Improve Pagination a11y by fixing a W3C error react-component/pagination#280 * update snapshot * 🆙 rc-pagination to 2.4.1 * feat: support triggerSubMenuAction for <Menu /> (#25127) * feat(menu): add triggerSubMenuAction for Menu * feat(menu): test cases * chore: Adjust picker logic (#25135) * chore: update rc-picker 1.10.0 (#25174) * feat: table row check strictly (#24931) * feat: add checkStrictly on Table.rowSelection * fix: LGTM warnings * test: table rowSelection.checkStrictly * test: add cov [wip] * refactor: tree.rowSelection.checkStrictly [wip] * test: table.rowSelection.checkStrictly basic case * feat: support rowKey on checkStrictly table * feat: Table checkStrictly support getCheckboxProps * docs: Table checkStrictly * chore: typo * chore: remove useless comment * chore: update snapshot * chore: update snapshot * fix: fire selectAll on selection dropdown menu & changeRows incorrect in selectAll callback * docs: typo * chore * chore * fix: expand buttons of leaf rows in tree data are not hidden * feat: Table warning about rowKey index parameter * perf: only generate keyEntities when not checkStrictly * refactor: remove useless parseCheckedKeys * refactor: get derived selected & half selected keys from selectedRowKeys * chore: remove env condition stmt * chore: revert index usage & code formatting * chore: rerun ci * docs: table tree-data checkstrictly * test: update snapshots * refactor: use useMergedState hook * chore: rerun ci * chore: rerun ci 2 * chore: revert selection select all behavior * refactor: refactor code based on feature * chore: revert table code format * chore: revert table code format * fix: useMemo deps * fix: useMemo deps * fix: useMemo deps * feat: support preserve (#25186) * docs: add responsibly order for Col (#25139) * feat: add type * feat: add responsibly order cols * feat: add docs * feat: add test case * fix test Co-authored-by: 二货机器人 <smith3816@gmail.com> Co-authored-by: 偏右 <afc163@gmail.com> Co-authored-by: zoomdong <1344492820@qq.com> Co-authored-by: 07akioni <07akioni2@gmail.com> Co-authored-by: wendellhu <wendellhu95@gmail.com> Co-authored-by: xrkffgg <xrkffgg@gmail.com> Co-authored-by: Neto Braghetto <netow93@gmail.com> Co-authored-by: Kermit Xuan <kermitlx@outlook.com> Co-authored-by: Ashkan Pourghasem <64011067+ashkan-pm@users.noreply.github.com> Co-authored-by: Ashkan Pourghasem <ashkan.pourghasem@gmail.com> Co-authored-by: hicrystal <295247343@qq.com> Co-authored-by: Crystal Gao <jinggao@ebay.com> Co-authored-by: Amumu <yoyo837@hotmail.com> Co-authored-by: Li Ming <armyiljfe@gmail.com>

pr-triage bot added the PR: draft label May 5, 2020

reviewflow bot assigned wzhudev May 5, 2020

wzhudev changed the base branch from master to feature May 5, 2020 05:55

afc163 reviewed May 6, 2020

View reviewed changes

components/dropdown/style/index.less Show resolved Hide resolved

wzhudev marked this pull request as ready for review May 17, 2020 08:56

pr-triage bot added PR: unreviewed and removed PR: draft labels May 17, 2020

wendellhu added 4 commits June 5, 2020 08:20

feat: dropdown support arrow prop

f31d296

close #22758

test: update snapshot

4452541

fix: fix dropdown cls names

4c9dd58

test: update snapshot

7ca46f6

test: update snapshot

3823e62

afc163 reviewed Jun 5, 2020

View reviewed changes

wendellhu added 2 commits June 5, 2020 18:43

doc: update demo

c291a8e

test: update demo snapshot

09a5c8c

afc163 reviewed Jun 5, 2020

View reviewed changes

components/dropdown/demo/arrow.md Outdated

Hover Me <DownOutlined />

</a>

</Dropdown>,

<div>

Copy link

Member

afc163 Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

<div>

<>

wendellhu added 2 commits June 5, 2020 18:59

demo

e8c152d

fix: snapshot

82a7d31

afc163 approved these changes Jun 5, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jun 5, 2020

afc163 merged commit 4512d46 into ant-design:feature Jun 5, 2020

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jun 5, 2020

chenshuai2144 mentioned this pull request Jun 29, 2020

docs: add 4.4.0 changelog #25242

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: dropdown support arrow #23869

feat: dropdown support arrow #23869

wzhudev commented May 5, 2020 •

edited by markdownify bot

Loading

ant-design-bot commented May 5, 2020 •

edited

Loading

codesandbox-ci bot commented May 5, 2020 •

edited

Loading

afc163 commented May 5, 2020

wzhudev commented May 5, 2020

afc163 commented May 6, 2020

wzhudev commented May 6, 2020

afc163 commented May 16, 2020

wzhudev commented May 16, 2020

afc163 commented May 21, 2020

wzhudev commented May 22, 2020

afc163 commented May 22, 2020

afc163 commented May 22, 2020

afc163 commented May 28, 2020

wzhudev commented May 28, 2020 •

edited

Loading

codecov bot commented May 29, 2020 •

edited

Loading

ant-design-bot commented Jun 5, 2020 •

edited

Loading

wzhudev commented Jun 5, 2020 •

edited

Loading

afc163 Jun 5, 2020

afc163 Jun 5, 2020

afc163 Jun 5, 2020

feat: dropdown support arrow #23869

feat: dropdown support arrow #23869

Conversation

wzhudev commented May 5, 2020 • edited by markdownify bot Loading

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

ant-design-bot commented May 5, 2020 • edited Loading

codesandbox-ci bot commented May 5, 2020 • edited Loading

afc163 commented May 5, 2020

wzhudev commented May 5, 2020

afc163 commented May 6, 2020

wzhudev commented May 6, 2020

afc163 commented May 16, 2020

wzhudev commented May 16, 2020

afc163 commented May 21, 2020

wzhudev commented May 22, 2020

afc163 commented May 22, 2020

afc163 commented May 22, 2020

afc163 commented May 28, 2020

wzhudev commented May 28, 2020 • edited Loading

codecov bot commented May 29, 2020 • edited Loading

Codecov Report

ant-design-bot commented Jun 5, 2020 • edited Loading

wzhudev commented Jun 5, 2020 • edited Loading

afc163 Jun 5, 2020

Choose a reason for hiding this comment

afc163 Jun 5, 2020

Choose a reason for hiding this comment

afc163 Jun 5, 2020

Choose a reason for hiding this comment

wzhudev commented May 5, 2020 •

edited by markdownify bot

Loading

ant-design-bot commented May 5, 2020 •

edited

Loading

codesandbox-ci bot commented May 5, 2020 •

edited

Loading

wzhudev commented May 28, 2020 •

edited

Loading

codecov bot commented May 29, 2020 •

edited

Loading

ant-design-bot commented Jun 5, 2020 •

edited

Loading

wzhudev commented Jun 5, 2020 •

edited

Loading