fix: InputNumber onChange type #23871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 44b063e:
|
Codecov Report
@@ Coverage Diff @@
## master #23871 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 364 364
Lines 7272 7272
Branches 2027 2028 +1
=======================================
Hits 7168 7168
Misses 104 104
Continue to review full report at Codecov.
|
afc163
changed the title
Merged
|
I don't understand why InputNumber addition type string? |
|
@letuan1206 see #12795 InputNumber's onChange may return a string. This is weird behaviour IMO, but until this is fixed the type defs need to reflect this fact. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
The type of
InputNumber'sonChangefunction was incomplete, leading to confusion and TypeErrors when used the wrong way. Fixes: #12795, which may have been prematurely closed.Would be great if this could also be backported to 3.x! ❤️
💡 Background and solution
Simply extended the union type, as explained by #12795 (comment)
📝 Changelog
As this is just a correction of the typedef I do not expect any breaking changes. Users may need to adjust their downstream code a bit to please the typechecker.
☑️ Self Check before Merge