Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormItem getValueProps warning #23875

Merged
merged 1 commit into from May 5, 2020
Merged

fix: FormItem getValueProps warning #23875

merged 1 commit into from May 5, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 5, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23873

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item get React warning for getValueProps.
🇨🇳 Chinese 修复 Form.Item 使用 getValueProps React 会报警的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 5, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dcf7cd2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented May 5, 2020

Codecov Report

Merging #23875 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23875   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         364      364           
  Lines        7272     7272           
  Branches     2028     1979   -49     
=======================================
  Hits         7168     7168           
  Misses        104      104           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8ffd4...dcf7cd2. Read the comment docs.

@zombieJ zombieJ merged commit 2a0df4f into master May 5, 2020
36 checks passed
@zombieJ zombieJ deleted the warning branch May 5, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants