Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drawer with percentage width cannot show when no mask #23925

Merged
merged 1 commit into from May 7, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 7, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23910

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Drawer width="50%" hidden problem when no mask.
🇨🇳 Chinese 修复无遮罩的 Drawer 设置 50% 宽度时不显示的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 7, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a623554:

Sandbox Source
antd reproduction template Configuration
Basic - Ant Design Demo Issue #23910

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #23925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23925   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7265     7265           
  Branches     2013     1975   -38     
=======================================
  Hits         7176     7176           
  Misses         89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee80a2f...a623554. Read the comment docs.

@afc163 afc163 merged commit 2ba90f7 into master May 7, 2020
35 checks passed
@afc163 afc163 deleted the fix-drawer-percentage-width branch May 7, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants