Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: πŸ†™ upgrade rc-animate to 3.x #23937

Merged
merged 3 commits into from May 8, 2020
Merged

refactor: πŸ†™ upgrade rc-animate to 3.x #23937

merged 3 commits into from May 8, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 7, 2020

#23930 (comment)

🌈  ant-design@4.2.0 git:❨esbuild❩ npm ls rc-animate                 
antd@4.2.0 /Users/afc163/Projects/ant-design
β”œβ”€β”¬ @ant-design/bisheng-plugin@2.3.0
β”‚ └─┬ antd@4.2.0
β”‚   └── rc-animate@2.11.1  deduped
β”œβ”€β”€ rc-animate@2.11.1 
β”œβ”€β”¬ rc-collapse@1.11.8
β”‚ └── rc-animate@2.11.1  deduped
β”œβ”€β”¬ rc-dialog@7.6.1
β”‚ └── rc-animate@2.11.1  deduped
β”œβ”€β”¬ rc-menu@8.0.3
β”‚ └── rc-animate@2.11.1  deduped
β”œβ”€β”¬ rc-notification@4.0.0
β”‚ └── rc-animate@2.11.1  deduped
β”œβ”€β”¬ rc-select@10.2.5
β”‚ └── rc-animate@2.11.1  deduped
β”œβ”€β”¬ rc-tree@3.1.9
β”‚ └── rc-animate@2.11.1  deduped
└─┬ rc-trigger@4.0.2
  └── rc-animate@2.11.1  deduped
  • rc-collapse
  • rc-dialog
  • rc-menu
  • rc-notification
  • rc-select
  • rc-tree
  • rc-trigger

It can reduce bundle size too: #22698


ι—΄ζŽ₯移陀了 css-animation ηš„δΎθ΅–οΌŒε―Ήη”¨ζˆ·ζ— η›΄ζŽ₯影响。

drop dep of component-classes
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 7, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8678154:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 changed the title refactor: πŸ†™ upgrade rc-animate to 3.x [WIP] refactor: πŸ†™ upgrade rc-animate to 3.x May 7, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label May 7, 2020
@codecov
Copy link

@codecov codecov bot commented May 7, 2020

Codecov Report

Merging #23937 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23937   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7266     7266           
  Branches     2013     2023   +10     
=======================================
  Hits         7177     7177           
  Misses         89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 968e7ed...8678154. Read the comment docs.

@afc163 afc163 mentioned this pull request May 7, 2020
26 tasks
@afc163 afc163 changed the title [WIP] refactor: πŸ†™ upgrade rc-animate to 3.x refactor: πŸ†™ upgrade rc-animate to 3.x May 8, 2020
@afc163 afc163 merged commit f8c1e79 into master May 8, 2020
32 of 34 checks passed
@afc163 afc163 deleted the rc-animate-3.x branch May 8, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants