Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormItem with help #23945

Merged
merged 5 commits into from May 7, 2020
Merged

fix: FormItem with help #23945

merged 5 commits into from May 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 7, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23882

close #23883

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item help style issue when validateStatus is not error.
🇨🇳 Chinese 修复 Form.Item helpvalidateStatus 不是 error 时的样式问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 7, 2020

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented May 7, 2020

jsdom 没有动画阶段,消失的 className 没法测,蛋疼

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b27af54:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #23882

afc163
afc163 approved these changes May 7, 2020
@codecov
Copy link

@codecov codecov bot commented May 7, 2020

Codecov Report

Merging #23945 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23945   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7267     7270    +3     
  Branches     2013     2025   +12     
=======================================
+ Hits         7178     7181    +3     
  Misses         89       89           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.15% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9fada3...b27af54. Read the comment docs.

@afc163 afc163 merged commit c4b602e into master May 7, 2020
36 checks passed
@afc163 afc163 deleted the status branch May 7, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants