Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix transfer search padding in rtl #23962

Merged
merged 1 commit into from
May 8, 2020
Merged

style: fix transfer search padding in rtl #23962

merged 1 commit into from
May 8, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Transfer search padding in RTL
🇨🇳 Chinese 修复 Transfer 查询框在 RTL 模式下的 padding

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 8, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6cc2b79:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #23962 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23962   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7270     7270           
  Branches     1976     1976           
=======================================
  Hits         7181     7181           
  Misses         89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612bcdf...6cc2b79. Read the comment docs.

@@ -35,7 +35,7 @@
}

&-search {
padding-right: 24px !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看看当初为啥加这个 !important,避免改挂。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没发现有啥问题

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有点记不起来了,不过试了下应该可以去掉。

@yoyo837 yoyo837 requested a review from AshoneA May 8, 2020 09:52
@afc163 afc163 merged commit 48c7011 into master May 8, 2020
@afc163 afc163 deleted the fix-transfer-rtl branch May 8, 2020 10:13
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants