Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: πŸ“¦ remove react-lifecycles-compat #23969

Merged
merged 1 commit into from May 8, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 8, 2020

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

#22698

πŸ’‘ Background and solution

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English
πŸ‡¨πŸ‡³ Chinese 移陀 react-lifecycles-compat 依衖δ»₯δΌ˜εŒ–εŒ…δ½“η§―γ€‚

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 8, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b6b2e2c:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 mentioned this pull request May 8, 2020
26 tasks
@afc163
Copy link
Member Author

afc163 commented May 8, 2020

减少了 0.4 kB~

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #23969 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23969      +/-   ##
==========================================
- Coverage   98.77%   98.73%   -0.05%     
==========================================
  Files         364      364              
  Lines        7270     7270              
  Branches     2025     2024       -1     
==========================================
- Hits         7181     7178       -3     
- Misses         89       92       +3     
Impacted Files Coverage Ξ”
components/carousel/index.tsx 93.75% <0.00%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update d221458...b6b2e2c. Read the comment docs.

@afc163 afc163 merged commit cc11b95 into master May 8, 2020
36 checks passed
@afc163 afc163 deleted the remove-react-lifecycles-compat branch May 8, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants