Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix input clear icon in rtl #23999

Merged
merged 1 commit into from May 9, 2020
Merged

style: fix input clear icon in rtl #23999

merged 1 commit into from May 9, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Input clear icon style in RTL
🇨🇳 Chinese 修复 Input 在 RTL 模式下清空按钮的样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 9, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6761c3:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented May 9, 2020

Codecov Report

Merging #23999 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23999   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         364      364           
  Lines        7270     7270           
  Branches     2014     2025   +11     
=======================================
  Hits         7181     7181           
  Misses         89       89           
Impacted Files Coverage Δ
components/input/ClearableLabeledInput.tsx 100.00% <100.00%> (ø)
components/input/TextArea.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a8736...a6761c3. Read the comment docs.

@afc163 afc163 merged commit dd6c855 into master May 9, 2020
36 checks passed
@afc163 afc163 deleted the fix-input-clear branch May 9, 2020
@ycjcl868 ycjcl868 mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants