Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Form.List render logic #24009

Merged
merged 3 commits into from May 10, 2020
Merged

chore: Fix Form.List render logic #24009

merged 3 commits into from May 10, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23978

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.List field status sync logic and add a nest fields demo.
🇨🇳 Chinese 修复 Form.List 字段状态同步逻辑并添加嵌套字段示例。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/dynamic-form-item.md
View rendered components/form/demo/dynamic-form-items.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 9, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 67cb901:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented May 9, 2020

Codecov Report

Merging #24009 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #24009   +/-   ##
========================================
  Coverage    98.75%   98.75%           
========================================
  Files          364      364           
  Lines         7297     7298    +1     
  Branches      2020     2021    +1     
========================================
+ Hits          7206     7207    +1     
  Misses          91       91           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.15% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741ff5c...67cb901. Read the comment docs.

afc163
afc163 approved these changes May 9, 2020
@zombieJ zombieJ merged commit 72a8466 into feature May 10, 2020
35 checks passed
@zombieJ zombieJ deleted the form branch May 10, 2020
@hengkx hengkx mentioned this pull request May 29, 2020
14 tasks
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants