Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Link component to prepare for rm global style #24019

Merged
merged 7 commits into from May 11, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 10, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #9363

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add Link component.
🇨🇳 Chinese 添加 Link 组件。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/link/demo/basic.md
View rendered components/link/index.en-US.md
View rendered components/link/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 10, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2953f5:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented May 10, 2020

Codecov Report

Merging #24019 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #24019   +/-   ##
========================================
  Coverage    98.83%   98.83%           
========================================
  Files          364      365    +1     
  Lines         7291     7307   +16     
  Branches      2027     2018    -9     
========================================
+ Hits          7206     7222   +16     
  Misses          85       85           
Impacted Files Coverage Δ
components/typography/Base.tsx 100.00% <100.00%> (ø)
components/typography/Link.tsx 100.00% <100.00%> (ø)
components/typography/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c7b86...a2953f5. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented May 10, 2020

Typography.Link 对应 Typography.Text 似乎很匹配。

https://ant.design/components/typography-cn/#components-typography-demo-basic 段落例子也有有链接。

afc163
afc163 approved these changes May 11, 2020
@zombieJ zombieJ merged commit 80e3dfa into feature May 11, 2020
33 of 34 checks passed
@zombieJ zombieJ deleted the rm-global-css branch May 11, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants