Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: descriptions add less variable #24032

Merged
merged 3 commits into from May 11, 2020
Merged

feat: descriptions add less variable #24032

merged 3 commits into from May 11, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented May 11, 2020

…ons-it,@descriptions-item-label-colon-margin-leftem-label-colon-margin-right,

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23998

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Descriptions add less variables @descriptions-item-trailing-colon and etc.
🇨🇳 Chinese Descriptions 新增 @descriptions-item-trailing-colon 等 less 变量。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

…ns-it,@descriptions-item-label-colon-margin-leftem-label-colon-margin-right,
@reviewflow reviewflow bot changed the title feat: descriptions add less variable feat: descriptions add less variable May 11, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 11, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af0e760:

Sandbox Source
antd reproduction template Configuration

components/descriptions/Cell.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented May 11, 2020

Codecov Report

Merging #24032 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #24032   +/-   ##
========================================
  Coverage    98.74%   98.74%           
========================================
  Files          364      364           
  Lines         7302     7302           
  Branches      2033     2033           
========================================
  Hits          7210     7210           
  Misses          92       92           
Impacted Files Coverage Δ
components/descriptions/Cell.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4884e91...af0e760. Read the comment docs.

afc163
afc163 approved these changes May 11, 2020
@afc163 afc163 merged commit d766472 into feature May 11, 2020
35 checks passed
@afc163 afc163 deleted the feat/23998 branch May 11, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants