Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transfer support oneWay #24041

Merged
merged 28 commits into from May 13, 2020
Merged

feat: Transfer support oneWay #24041

merged 28 commits into from May 13, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 11, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

image

https://preview-24041-ant-design.surge.sh/components/transfer-cn/#components-transfer-demo-basic

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Transfer support oneWay and pagination.
🇨🇳 Chinese Transfer 支持 oneWay 配置单向选择以及 pagination 配置分页。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/transfer/demo/basic.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 11, 2020

@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 2 alerts when merging 1227693 into d766472 - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8882406431eb0a8e444a5bf51df3fe139ba132b:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

afc163 commented May 11, 2020

要把批量删除的交互考虑一下,不然要一个个点。

@zombieJ
Copy link
Member Author

zombieJ commented May 11, 2020

要把批量删除的交互考虑一下,不然要一个个点。

嗯,会加一个批处理下啦。还在和设计师对。

@afc163
Copy link
Member

afc163 commented May 12, 2020

image

  1. 无交互区域不要手型。
  2. 删除按钮要有 hover 效果。

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2020

This pull request introduces 2 alerts when merging 8b582c5 into f250b2f - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2020

This pull request introduces 2 alerts when merging c931bdf into f250b2f - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2020

This pull request introduces 2 alerts when merging d3b8134 into f250b2f - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2020

This pull request introduces 2 alerts when merging 76aca90 into f250b2f - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@afc163
Copy link
Member

afc163 commented May 12, 2020

rebase

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2020

This pull request introduces 2 alerts when merging 666f2fe into f250b2f - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2020

This pull request introduces 2 alerts when merging 700ee95 into f250b2f - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2020

This pull request introduces 2 alerts when merging 216f856 into f250b2f - view on LGTM.com

new alerts:

  • 2 for Useless conditional

@zombieJ zombieJ changed the title [WIP] feat: Transfer support oneWay feat: Transfer support oneWay May 13, 2020
@zombieJ
Copy link
Member Author

zombieJ commented May 13, 2020

  • hover 上箭头的时候,指针要改成手型
  • 选中的行,再 hover 上的时候,是蓝色

@zombieJ zombieJ marked this pull request as ready for review May 13, 2020
@afc163
Copy link
Member

afc163 commented May 13, 2020

还是不能批量选择删除,要么删一个,要么删全部。

@afc163
Copy link
Member

afc163 commented May 13, 2020

oneWay 单独搞个 demo 吧,这样用户容易发现有这个功能。

@afc163
Copy link
Member

afc163 commented May 13, 2020

image

这个图标的响应区域建议扩大,现在比较难点。

afc163
afc163 approved these changes May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #24041 into feature will decrease coverage by 0.03%.
The diff coverage is 97.56%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #24041      +/-   ##
===========================================
- Coverage    98.73%   98.69%   -0.04%     
===========================================
  Files          365      365              
  Lines         7324     7424     +100     
  Branches      1987     2056      +69     
===========================================
+ Hits          7231     7327      +96     
- Misses          93       97       +4     
Impacted Files Coverage Δ
components/locale/default.tsx 100.00% <ø> (ø)
components/locale/zh_CN.tsx 100.00% <ø> (ø)
components/_util/transButton.tsx 96.77% <85.71%> (-3.23%) ⬇️
components/transfer/list.tsx 97.87% <95.31%> (-2.13%) ⬇️
components/transfer/ListBody.tsx 100.00% <100.00%> (ø)
components/transfer/ListItem.tsx 100.00% <100.00%> (ø)
components/transfer/index.tsx 100.00% <100.00%> (ø)
components/transfer/operation.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41dd956...9901385. Read the comment docs.

@zombieJ zombieJ merged commit b0e528d into feature May 13, 2020
16 of 18 checks passed
@zombieJ zombieJ deleted the transfer branch May 13, 2020
@afc163
Copy link
Member

afc163 commented May 22, 2020

image

未覆盖行数增加了 4 行,补充一下用例。

@afc163 afc163 mentioned this pull request May 22, 2020
2 tasks
@xrkffgg xrkffgg mentioned this pull request May 29, 2020
17 tasks
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants