feat: Adds zh_TW localisations for Form #24065
Merged
+79
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b1eda14:
|
Codecov Report
@@ Coverage Diff @@
## master #24065 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 364 364
Lines 7290 7291 +1
Branches 2028 2028
=======================================
+ Hits 7205 7206 +1
Misses 85 85
Continue to review full report at Codecov.
|
xrkffgg
reviewed
May 12, 2020
components/locale/zh_TW.tsx
Outdated
| import Pagination from 'rc-pagination/lib/locale/zh_TW'; | ||
| import DatePicker from '../date-picker/locale/zh_TW'; | ||
| import TimePicker from '../time-picker/locale/zh_TW'; | ||
| import Calendar from '../calendar/locale/zh_TW'; | ||
| import { Locale } from '../locale-provider'; | ||
|
|
||
| const typeTemplate = '${label}不是一个有效的${type}'; |
There was a problem hiding this comment.
Suggested change
| const typeTemplate = '${label}不是一个有效的${type}'; | |
| const typeTemplate = '${label}不是一個有效的${type}'; |
components/locale/zh_TW.tsx
Outdated
| const localeValues: Locale = { | ||
| locale: 'zh-tw', | ||
| Pagination, | ||
| DatePicker, | ||
| TimePicker, | ||
| Calendar, | ||
| global: { | ||
| placeholder: '請選擇', | ||
| }, | ||
| Table: { | ||
| filterTitle: '篩選器', | ||
| filterConfirm: '確 定', | ||
| filterReset: '重 置', |
There was a problem hiding this comment.
Suggested change
| filterReset: '重 置', | |
| filterReset: '重置', |
components/locale/zh_TW.tsx
Outdated
| collapse: '關閉行', | ||
| triggerDesc: '點擊降序', | ||
| triggerAsc: '點擊升序', | ||
| cancelSort: '取消排序', | ||
| }, | ||
| Modal: { | ||
| okText: '確 定', |
xrkffgg
approved these changes
May 12, 2020
|
请更新一下snapshot |
xrkffgg
reviewed
May 12, 2020
components/locale/zh_TW.tsx
Outdated
| okText: '確 定', | ||
| cancelText: '取 消', | ||
| okText: '確定', | ||
| cancelText: '取消', | ||
| justOkText: 'OK', |
There was a problem hiding this comment.
Suggested change
| justOkText: 'OK', | |
| justOkText: '知道了', |
60 tasks
afc163
reviewed
May 12, 2020
| @@ -220,7 +220,7 @@ describe('Locale Provider', () => { | |||
| '.ant-btn:not(.ant-btn-primary) span', | |||
| )[0].innerHTML; | |||
| let okButtonText = currentConfirmNode.querySelectorAll('.ant-btn-primary span')[0].innerHTML; | |||
| if (locale.locale === 'zh-cn') { | |||
| if (locale.locale === 'zh-cn' || locale.locale === 'zh-tw') { | |||
There was a problem hiding this comment.
locale.locale.indexOf('zh-') === 0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#23369
The missing fields for the traditional Chinese language had been added. It is updated based on the zh_CH and en_US file.
zh_TWlocalisations