Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drawer height bug #24082

Merged
merged 2 commits into from May 12, 2020
Merged

fix: Drawer height bug #24082

merged 2 commits into from May 12, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24074
close #24188

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English - Fix Drawer getContainer={false} height overflow issue.
- Fix Drawer mask={false} animation not working.
🇨🇳 Chinese - 修复 Drawer getContainer={false} 时的高度问题。
- 修复 Drawer mask={false} 时隐藏动画不生效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title fix Drawer height bug fix: Drawer height bug May 12, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 12, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be4ce50:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #24082 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24082   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         364      364           
  Lines        7292     7296    +4     
  Branches     1981     2031   +50     
=======================================
+ Hits         7206     7210    +4     
  Misses         86       86           
Impacted Files Coverage Δ
components/drawer/index.tsx 98.83% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcbfc9...be4ce50. Read the comment docs.

@afc163 afc163 merged commit 82d7096 into master May 12, 2020
35 checks passed
@afc163 afc163 deleted the fix-drawer-height branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants