Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Child of Button should be interactive #24095

Merged
merged 1 commit into from May 12, 2020
Merged

fix: Child of Button should be interactive #24095

merged 1 commit into from May 12, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24090

ref #7034

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button children not working with Tooltip.
🇨🇳 Chinese 修复 Button 内图标无法使用 Tooltip 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 12, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented May 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d5801f:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #24090

@codecov
Copy link

@codecov codecov bot commented May 12, 2020

Codecov Report

Merging #24095 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24095   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         364      364           
  Lines        7297     7297           
  Branches     2031     1982   -49     
=======================================
  Hits         7211     7211           
  Misses         86       86           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d151a...0d5801f. Read the comment docs.

@afc163 afc163 merged commit c19685e into master May 12, 2020
27 of 29 checks passed
@afc163 afc163 deleted the fix-build-child branch May 12, 2020
@cjmafei
Copy link
Contributor

@cjmafei cjmafei commented Jul 10, 2020

Why do you revert this PR? @afc163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants