Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch - no correct animation on the IOS/Chrome #24122

Merged
merged 1 commit into from May 13, 2020

Conversation

lexlexa
Copy link
Contributor

@lexlexa lexlexa commented May 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24087
fix #19915

💡 Background and solution

  1. The animation does not work correctly on the IOS in the Chrome browser
    Step to reproduce:
  • Open page
  • Collapse browser tab
  • Create new tab
  • Open previous tab
  • Animations not worked
  1. GIF

  2. Solution
    Do not use relative units (%)
    I use calculated values ​​from LESS variables

📝 Changelog

Language Changelog
🇺🇸 English Fix Switch shake in safari and iOS Chrome.
🇨🇳 Chinese 修复 Switch 在 safari 和 iOS Chrome 上点击时错位的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 13, 2020

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 13, 2020

Pls rebase and run npm test -- -u

@afc163
Copy link
Member

@afc163 afc163 commented May 13, 2020

rebase master

@codecov
Copy link

@codecov codecov bot commented May 13, 2020

Codecov Report

Merging #24122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24122   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         364      364           
  Lines        7297     7297           
  Branches     2031     2031           
=======================================
  Hits         7211     7211           
  Misses         86       86           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d03db0...479113f. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented May 13, 2020

This also resolves #19915! Thx! @lexlexa

@afc163 afc163 merged commit fd7c942 into ant-design:master May 13, 2020
22 checks passed
@zombieJ
Copy link
Member

@zombieJ zombieJ commented May 18, 2020

截屏2020-05-18 上午10 49 47

Breaks longer title

@zombieJ zombieJ mentioned this pull request May 18, 2020
1 task
zombieJ added a commit that referenced this issue May 18, 2020
zombieJ added a commit that referenced this issue May 18, 2020
* Revert "fix switch ios chrome animation (#24122)"

This reverts commit fd7c942.

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants