Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 🆙 upgrade rc-progress #24127

Merged
merged 2 commits into from May 13, 2020
Merged

refactor: 🆙 upgrade rc-progress #24127

merged 2 commits into from May 13, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24116

💡 Background and solution

Refactor rc-progress: react-component/progress@9e6160f

📝 Changelog

Language Changelog
🇺🇸 English Refactor rc-progress to resolve h3g is not defined error in <script src"antd.min.js" />.
🇨🇳 Chinese 重构 rc-progress 以解决 <script src"antd.min.js" /> 会抛出 h3g is not defined 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 13, 2020

@codecov
Copy link

@codecov codecov bot commented May 13, 2020

Codecov Report

Merging #24127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24127   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         364      364           
  Lines        7297     7297           
  Branches     2031     2032    +1     
=======================================
  Hits         7211     7211           
  Misses         86       86           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6093f11...85072b2. Read the comment docs.

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 13, 2020

为啥你的CI 不报错

@afc163 afc163 changed the title chore: 🆙 upgrade rc-progress refactor: 🆙 upgrade rc-progress May 13, 2020
@afc163
Copy link
Member Author

@afc163 afc163 commented May 13, 2020

你本地 node_modules 是旧的。

@afc163 afc163 merged commit 9d03db0 into master May 13, 2020
35 checks passed
@afc163 afc163 deleted the upgrade-rc-progress branch May 13, 2020
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 13, 2020

我确定我每次都删过,本地能通

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 13, 2020

我换cnpm试试

@afc163
Copy link
Member Author

@afc163 afc163 commented May 13, 2020

bundle size 降低了近 1 kB。

@afc163
Copy link
Member Author

@afc163 afc163 commented May 13, 2020

package-lock.json 或者 yarn.lock

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 13, 2020

失算了。😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants