Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown button default placement in rtl #24150

Merged
merged 2 commits into from May 14, 2020
Merged

fix: dropdown button default placement in rtl #24150

merged 2 commits into from May 14, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Before

image

After

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Dropdown.Button default menu placement in RTL
🇨🇳 Chinese 修复 Dropdown.Button 下拉框在 RTL 模式下默认位置

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 14, 2020

@codecov
Copy link

@codecov codecov bot commented May 14, 2020

Codecov Report

Merging #24150 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24150   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         364      364           
  Lines        7297     7300    +3     
  Branches     2032     2034    +2     
=======================================
+ Hits         7211     7214    +3     
  Misses         86       86           
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7c942...30ef736. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented May 14, 2020

覆盖率要提升一下。

@xrkffgg xrkffgg requested a review from afc163 May 14, 2020
@afc163 afc163 merged commit 5d9d45b into master May 14, 2020
34 checks passed
@afc163 afc163 deleted the fix-dropdown-rtl branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants