fix: Backtop cannot work in Chrome iframe #24194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
afc163
changed the title
afc163
commented
May 15, 2020
| @@ -24,8 +24,8 @@ export default function scrollTo(y: number, options: ScrollToOptions = {}) { | |||
| const nextScrollTop = easeInOutCubic(time > duration ? duration : time, scrollTop, y, duration); | |||
| if (isWindow(container)) { | |||
| (container as Window).scrollTo(window.pageXOffset, nextScrollTop); | |||
| } else if (container instanceof Document) { | |||
| container.documentElement.scrollTop = nextScrollTop; | |||
| } else if (container instanceof HTMLDocument || container.constructor.name === 'HTMLDocument') { | |||
There was a problem hiding this comment.
Chrome 下 element.ownerDocument instanceof HTMLDocument 是 false，比较奇怪。
|
|
Codecov Report
@@ Coverage Diff @@
## master #24194 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 364 364
Lines 7291 7291
Branches 2019 1970 -49
=======================================
Hits 7205 7205
Misses 86 86
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #24192
💡 Background and solution
#22788 没有修干净，Chrome 下还是不能用。
📝 Changelog
☑️ Self Check before Merge